Refactor rqt plot #232
Closed
Refactor rqt plot #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses several bugs: * It wasn't possible to close topic views when running standalone * If topic views were closed (non-standalone), it wasn't possible to open them again This also moves the logic for handling open/close interactions out of the TopicMessageView class, where they might not always be called, and into the owning class instead
|
Merge after #230 |
This was referenced May 27, 2014
|
#236 contains all these diffs. I will close this one and test that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out the plot backend into a proper abstraction so that I can attempt to use it elsewhere
Future work will probably move the plot abstraction into rqt_py_common