Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test_bond dependency from bond_core #79

Merged
merged 1 commit into from
May 28, 2021
Merged

Remove test_bond dependency from bond_core #79

merged 1 commit into from
May 28, 2021

Conversation

mjcarroll
Copy link
Member

Signed-off-by: Michael Carroll [email protected]

clalancette
clalancette approved these changes May 28, 2021
View reviewed changes
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; there is really no reason to release this into the distributions. We should also backport this to the foxy-devel branch.

@mjcarroll
Copy link
Member Author

Tests fail, this is known and addressed in #76

@mjcarroll mjcarroll merged commit 3505c3f into ros2 May 28, 2021
@mjcarroll mjcarroll deleted the fix_metapackage branch May 28, 2021 15:34
mjcarroll added a commit that referenced this pull request May 28, 2021
@mjcarroll
Remove test_bond dependency from bond_core (#79)
596e3fc 
Signed-off-by: Michael Carroll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @clalancette