Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of deprecated logging functions #271

Open
mikepurvis opened this issue Oct 20, 2017 · 4 comments
Open

Use of deprecated logging functions #271

mikepurvis opened this issue Oct 20, 2017 · 4 comments
Labels
enhancement

Comments

@mikepurvis
Copy link
Member

See: https://github.com/ros/console_bridge/blob/master/include/console_bridge/console.h#L68-L90

https://github.com/ros/geometry2/search?q=logWarn

https://github.com/ros/geometry2/search?q=logError
@tfoote
Copy link
Member

tfoote commented Oct 20, 2017

Like: ros/rosconsole_bridge#14 (comment) We can't fix this until we fork development away from Indigo.

@mikaelarguedas
Copy link
Member

I faced the same issue recently on another package. You could work around it if you don't want to branch out just for this change: https://github.com/ros/class_loader/pull/52/files#diff-2777c9ef40eb99c5dbc7f68d8ff4a34f

@racko racko mentioned this issue Jan 4, 2018
Closed
@AlphaJi
Copy link

AlphaJi commented Feb 27, 2018

I face the same problem, and I have to modify buffer_core.cpp to work around this.

@TaylorDixonHD
Copy link

I faced the same issue, fix was to edit buffer_core.cpp by appending CONSOLE_BRIDGE_ to every occurrence of logError/logWarning (log* in general).

seanyen pushed a commit to ms-iot/geometry2 that referenced this issue Aug 18, 2020
@dirk-thomas
[tf2_ros, tf2_geometry_msgs] export targets in addition to include di…
5880ce9 
…rectories / libraries (ros#271)

* [tf2_ros] export targets in addition to include directories / libraries

Signed-off-by: Dirk Thomas <[email protected]>

* add missing exported dependencies

Signed-off-by: Dirk Thomas <[email protected]>

* [tf2_geometry_msgs] export targets in addition to include directories / libraries

Signed-off-by: Dirk Thomas <[email protected]>

* remove install / export_include_dirs which is redundant with ament_auto_package()

Signed-off-by: Dirk Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tfoote @mikepurvis @mikaelarguedas @TaylorDixonHD @AlphaJi