Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to transform not only point positions, but also other 3D-data channels. #396

Open
wants to merge 2 commits into
base: noetic-devel
Choose a base branch
from
Open

Added ability to transform not only point positions, but also other 3D-data channels. #396

wants to merge 2 commits into from

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Jul 10, 2019 •
edited
Loading

Solves #387 and adds more functionality that might come handy to people who also use other 3D-data channels in pointclouds.

@peci1 peci1 mentioned this pull request Jul 10, 2019
Open
@tfoote tfoote self-requested a review July 12, 2019 01:11
@tfoote tfoote self-assigned this Jul 12, 2019
@roncapat
Copy link

roncapat commented May 2, 2022 •
edited
Loading

Any news?

It is quite important to rotate normals in particular... It is quite surprising that ROS never had this feature :)

@peci1
Copy link
Contributor Author

peci1 commented May 2, 2022

In a few days, I should be releasing our (so far private) utility library cras_cpp_common which contains an even more versatile tool for working with pointclouds with direction- and point-like channels. I'll post a link here once it is live.

But having this PR merged would definitely be nice so that the functionality is directly in the core ROS libraries.

@peci1
Copy link
Contributor Author

peci1 commented Feb 14, 2023

This has been implemented in http://docs.ros.org/en/melodic/api/cras_cpp_common/html/tf2__sensor__msgs_8h.html . Install ros-${ROS_DISTRO}-cras-cpp-common and you're a go!

@ahcorde
Copy link
Contributor

ahcorde commented Feb 2, 2024

This PR is targeting a EOL distribution melodic, closing this PR, feel free to reopen this against a maintained branch

@ahcorde ahcorde closed this Feb 2, 2024
@peci1
Copy link
Contributor Author

peci1 commented Feb 2, 2024

@ahcorde Can you reopen this PR? I can't change the base when it is closed... Or should I rather open a new one?

@ahcorde ahcorde reopened this Feb 2, 2024
@ahcorde ahcorde changed the base branch from melodic-devel to noetic-devel February 2, 2024 21:40
@peci1
Copy link
Contributor Author

peci1 commented Feb 3, 2024

Thanks for reopening. The tests are green.

ahcorde
ahcorde reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfoote ?

tf2_sensor_msgs/include/tf2_sensor_msgs/tf2_sensor_msgs.h Outdated Show resolved Hide resolved
@peci1 @ahcorde
Fixed typo
e0caba2 
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@peci1
Copy link
Contributor Author

peci1 commented Apr 16, 2024

@tfoote would you find a while for reviewing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde left review comments

@tfoote tfoote Awaiting requested review from tfoote tfoote is a code owner

Assignees

@tfoote tfoote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peci1 @roncapat @ahcorde @tfoote