Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doTransform() for Eigen::Quaternion #496

Open
wants to merge 4 commits into
base: noetic-devel
Choose a base branch
from
Open

fix doTransform() for Eigen::Quaternion #496

wants to merge 4 commits into from

Conversation

gleichdick
Copy link

Backport of ros2/geometry2#369

ooeygui pushed a commit to ms-iot/geometry2 that referenced this pull request Oct 12, 2022
@sloretz
Export a tf2_geometry_msgs::tf2_geometry_msgs target (ros#496)
9e94db4 
* Export a tf2_geometry_msgs::tf2_geometry_msgs target

Signed-off-by: Shane Loretz <[email protected]>

* Comment that tf2_ros is used but intentionally not linked

Signed-off-by: Shane Loretz <[email protected]>
peci1
peci1 suggested changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@peci1 peci1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this was merged into ROS 2, is there anything blocking this PR?

It seems to me tf2_ros is a test-only dependency, but it was added as <depend>. Could you change it to <test_depend> only, please? (and do according changes in CMakeLists)

@ahcorde ahcorde added the noetic label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peci1 peci1 peci1 requested changes

@tfoote tfoote Awaiting requested review from tfoote tfoote is a code owner

Assignees
No one assigned
Labels
noetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gleichdick @peci1 @ahcorde