Fix use of deprecated logging functions. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indigo does not have the necessary version of |
|
@mikepurvis How do you want to proceed on this? |
|
It doesn't really matter to me. I just periodically try to clean some of the low-hanging fruit as far as warnings in our builds. If you guys want to fork for Kinetic+, that's reasonable, or I can put up a PR that does undef tricks suggested by @mikaelarguedas. |
|
Since this repo has a very low rate of changes I am fine with branching. I created a |
|
I retargeted the new branch. Thank you for fixing the warnings. |
|
For the record: ros/rosdistro#16146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/ros/console_bridge/blob/master/include/console_bridge/console.h#L68-L90