Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake to pass along console_bridge #1

Merged
merged 1 commit into from
Dec 5, 2012
Merged

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Dec 5, 2012

It was not passing along rosconsole or console_bridge correctly.

It was find_package'ing after catkin_package.

It was not treating console_bridge like a catkin dependency.

Also changed it to depend on console_bridge
like a catkin dependency.
isucan added a commit that referenced this pull request Dec 5, 2012
Update cmake to pass along console_bridge
@isucan isucan merged commit ff1306c into master Dec 5, 2012
@wjwwood
Copy link
Member Author

wjwwood commented Dec 5, 2012

@dirk-thomas Fixed the style things, but @isucan already released it, so I pushed it to master, it will get into the next release.

@isucan
Copy link
Contributor

isucan commented Dec 5, 2012

@wjwwood the commit does not seem to change much: 6398a4b
I tried to fix what @dirk-thomas said as well :) Do we need a re-release?

@wjwwood
Copy link
Member Author

wjwwood commented Dec 5, 2012

http://ros.org/doc/groovy/api/catkin/html/user_guide/package.html

I would think that we can just leave it till the next release, but that is
up to @dirk-thomas

On Wed, Dec 5, 2012 at 10:18 AM, isucan [email protected] wrote:

@wjwwood https://github.com/wjwwood the commit does not seem to change
much: 6398a4bhttps://github.com/ros/rosconsole_bridge/commit/6398a4b6673d642118c96845562b1df498556c80
I tried to fix what @dirk-thomas https://github.com/dirk-thomas said as
well :) Do we need a re-release?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-11053455.

William Woodall
Willow Garage - Software Engineer
[email protected]

@dirk-thomas
Copy link
Member

Sure, just style - it fine if it is just committed - does not need to be released.

dirk-thomas pushed a commit that referenced this pull request Jan 28, 2019
* Enable Windows Build (#1)

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update CMakeLists.txt

* Add ROSCONSOLE_BRIDGE_DECL for RegisterOutputHandlerProxy class

* fix path.

* Update CMakeLists.txt

* add empty line after macro definition (#2)

* add dependency for cpp_common explicitly

* also add run_depend on cpp_common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants