Allow parsing of multiple visual or collision elements #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
approved these changes
Feb 14, 2018
There was a problem hiding this comment.
This one looks OK to me (and there is no obvious breakage of the direct downstream consumers). @sloretz , any additional thoughts before I merge this?
sloretz
approved these changes
Feb 14, 2018
|
Thanks Shane. Merging. |
prashanthr05
added a commit
to prashanthr05/icub-model-generator
that referenced
this pull request
Aug 12, 2019
Using urdf_parser_py's commit 31474b9baaf7c3845b40e5a9aa87d5900a2282c3, that precedes the regression introduced in ros/urdf_parser_py#26 (ros/urdf_parser_py#26) and discussed in robotology/simmechanics-to-urdf#36 (robotology/simmechanics-to-urdf#36). The commit used is based from the info contained in this icub-models commit: robotology/icub-models@b69b989 (robotology/icub-models@b69b989).
prashanthr05
added a commit
to robotology/icub-models-generator
that referenced
this pull request
Sep 18, 2019
Using urdf_parser_py's commit 31474b9baaf7c3845b40e5a9aa87d5900a2282c3, that precedes the regression introduced in ros/urdf_parser_py#26 (ros/urdf_parser_py#26) and discussed in robotology/simmechanics-to-urdf#36 (robotology/simmechanics-to-urdf#36). The commit used is based from the info contained in this icub-models commit: robotology/icub-models@b69b989 (robotology/icub-models@b69b989).
traversaro
added a commit
to robotology/icub-models-generator
that referenced
this pull request
Nov 29, 2019
# Fix the way the FT IMU frames are added - add individual accelerometer and gyroscope type frames to the associated IMU frame - fix naming conventions - sensorName to be all in small letters - do not export these frames as zero-mass links in the urdf - just add these frames as sensor frames to the associated link # Use latest known working version of deps: Use latest confirmed working version of urdf_parser_py Using urdf_parser_py's commit 31474b9baaf7c3845b40e5a9aa87d5900a2282c3, that precedes the regression introduced in ros/urdf_parser_py#26 (ros/urdf_parser_py#26) and discussed in robotology/simmechanics-to-urdf#36 (robotology/simmechanics-to-urdf#36). The commit used is based from the info contained in this icub-models commit: robotology/icub-models@b69b989 (robotology/icub-models@b69b989). * Increase tolerance as a workaround for known asimmetry, see #125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now re-targeted at
melodic-develwith suggested issues addressed