Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-interactive launch.LaunchService runs #475

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Support non-interactive launch.LaunchService runs #475

merged 3 commits into from
Dec 21, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Dec 16, 2020

Connected to #473. This patch allows the user to modify the underlying assumption launch currently makes about Ctrl+C behavior i.e. sent to all processes in the process group. In the same vein as bash interactive/non-interactive shells (see here).

@hidmic hidmic mentioned this pull request Dec 16, 2020
Merged
@hidmic
Copy link
Contributor Author

hidmic commented Dec 16, 2020

I have not added regression tests yet. I plan to. At the very least, check the right events get sent.

wjwwood
wjwwood approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@hidmic
Copy link
Contributor Author

hidmic commented Dec 21, 2020

CI up to launch, launch_ros, test_launch_ros, test_communication:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor Author

hidmic commented Dec 21, 2020

Thanks for the review guys!

@hidmic hidmic merged commit 55ca523 into master Dec 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/non-interactive-launch branch December 21, 2020 21:07
@hidmic hidmic mentioned this pull request Mar 30, 2021
Closed
@hidmic
Copy link
Contributor Author

hidmic commented Mar 30, 2021

@jacobperron how do you feel about backporting this to Foxy?

@jacobperron
Copy link
Member

@jacobperron how do you feel about backporting this to Foxy?

Sounds okay to me 👍

@felixdivo
Copy link

Who would be responsible for that? Is there more involved then cherry-picking these three commits to a new branch targeted at branch foxy?

@jacobperron
Copy link
Member

Who would be responsible for that? Is there more involved then cherry-picking these three commits to a new branch targeted at branch foxy?

Anyone is welcome to propose a backport PR targeting the foxy branch (just as you've described; cherry-picking the relevant commits). If you do, feel free to mention me and/or hidmic.

This was referenced Apr 3, 2021
Merged
Merged
jacobperron pushed a commit that referenced this pull request Apr 5, 2021
@felixdivo @hidmic
Support non-interactive launch.LaunchService runs (#475) (#500)
c785866 
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Felix Divo <[email protected]>

Co-authored-by: Michel Hidalgo <[email protected]>
This was referenced Oct 8, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@wjwwood wjwwood wjwwood approved these changes

@jacobperron jacobperron Awaiting requested review from jacobperron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hidmic @jacobperron @felixdivo @wjwwood @ivanpauno