Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to support set node options in launch file? #84

Closed
xhuan28 opened this issue Oct 10, 2019 · 2 comments
Closed

Is it possible to support set node options in launch file? #84

xhuan28 opened this issue Oct 10, 2019 · 2 comments

Comments

@xhuan28
Copy link

xhuan28 commented Oct 10, 2019

I have two ComposableNode in launch.py and execute them in a single process. However, there is not any performance improvement compared with running them in two processes respectively, in terms of latency and throughput(measured by ros2 topic delay and ros2 topic hz). Is it expected?
After the observation, I would like to make them run in a single process with memory zero-copy. As far as I know, it can be set by intra_process_comm of rclcpp::NodeOptions, but I don't know how to make it in launch file. Anyone can help?

@fujitatomoya
Copy link
Contributor

i don't think currently we can do that.

but will be possible once ros2/rclcpp#871 is done.

@xhuan28
Copy link
Author

xhuan28 commented Oct 11, 2019

I verified that it works after applying ros2/rclcpp#871. Thanks.

@xhuan28 xhuan28 closed this as completed Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants