Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rclcpp_components] Enable intra-process comm via LoadNode request. #871

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Sep 24, 2019

Look for a 'use_intra_process_comms' boolean in extra_arguments.

Look for a 'use_intra_process_comms' boolean in extra_arguments.

Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic
Copy link
Contributor Author

hidmic commented Sep 24, 2019

We don't do much testing for rclcpp_components, do we? The most relevant one, test_component_manager_api , consistently fails and I bet it has to do with repeated node bring up / tear down.

I plan to test this manually, but until ros2/rcl#508 and friends are in ros2 component is broken.

@mjcarroll
Copy link
Member

I believe that it recently went from flaky to more consistently failing, I opened an issue here: #863

Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Mich!

@hidmic
Copy link
Contributor Author

hidmic commented Oct 7, 2019

Running CI up to rclcpp_components:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • OSX Build Status
  • Windows Build Status

@hidmic hidmic merged commit 07cb443 into master Oct 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/intra-process-comm-for-components branch October 10, 2019 16:14
@iluetkeb
Copy link
Contributor

iluetkeb commented Nov 7, 2019

@hidmic Is there an example for how to use this in a launch file?

btw, I'm sure you guys must have plenty of example launch files that the community could have a look at, to figure out how to actually use launch properly. putting them somewhere would be awesome.

Edit: This is not in dashing, yet, right?

@ZhenshengLee
Copy link

@hidmic Is there an example for how to use this in a launch file?

btw, I'm sure you guys must have plenty of example launch files that the community could have a look at, to figure out how to actually use launch properly. putting them somewhere would be awesome.

@iluetkeb
the extra_arguments is here, define a ComposableNode with this parameter I guess.

https://github.com/ros2/launch_ros/blob/79f783b1fe5e06d71737e2955a8f4eb9c4f3923c/launch_ros/launch_ros/descriptions/composable_node.py#L39-L60

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants