Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added include dir to installation of rcl_logging_log4cxx. #7

Merged
merged 1 commit into from
May 1, 2019

Conversation

rasmusan
Copy link
Contributor

Fixes issue #5. This enables compiling ROS2 with log4cxx (by setting RCL_LOGGING_IMPLEMENTATION to rcl_logging_log4cxx).

@nburek
Copy link
Contributor

nburek commented Apr 30, 2019

@thomas-moulard - please run the following CI job:

@thomas-moulard
Copy link

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich nuclearsandwich self-assigned this Apr 30, 2019
@tfoote
Copy link

tfoote commented May 1, 2019

This looks like an unrelated flake8 regressions in the idl generator on all platforms.

Error Message
'rosidl_parser.definition.SIGNED_INTEGER_TYPES' imported but unused:
from rosidl_parser.definition import SIGNED_INTEGER_TYPES
Standard Output
Checked files:
* ./rosidl_generator_c/__init__.py

Possibly related to ros2/rosidl#371 @jacobperron

@nburek
Copy link
Contributor

nburek commented May 1, 2019

Looks like the regression may have been fixed here too: ros2/rosidl#373

@thomas-moulard
Copy link

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me with green CI.

@tfoote
Copy link

tfoote commented May 1, 2019

The CI failed some tests. This is now hitting a LaunchTestService import error on all platforms and rmws that looks unrelated to this change.

../../../../build/rcl/test/test/test_services__rmw_connext_cpp_.py:6: in <module>
    from launch_testing import LaunchTestService
E   ImportError: cannot import name 'LaunchTestService'

There's a recent change related here: ros2/rcl#405

@clalancette
Copy link
Contributor

Oh, I see what happened. We merged ros2/rcl#405, which means that ros2/rcl#425 needs a rebase now. As @dirk-thomas suggested, this is only installing stuff that wasn't there before, so I'm going to merge this anyway.

@clalancette clalancette merged commit 220b7e4 into ros2:master May 1, 2019
@dirk-thomas dirk-thomas added the bug Something isn't working label May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants