Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conversion of negative durations to messages #1188

Merged
merged 6 commits into from
Jun 29, 2020
Merged

Fix conversion of negative durations to messages #1188

merged 6 commits into from
Jun 29, 2020

Commits on Jun 19, 2020

  1. Fix conversion from negative Duration or Time to the respective messa… 

    …ge type

... and throw in Duration::to_rmw_time() if the duration is negative.
rmw_time_t cannot represent negative durations.

Constructors and assignment operators can be just defaulted.

Other changes are mainly cosmetical, to make conversions between signed
and unsigned types and between 32-bit and 64-bit types more explicit.

Signed-off-by: Johannes Meyer <[email protected]>
    @meyerj
    meyerj committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    597817d View commit details
    Browse the repository at this point in the history

  2. Add -Wconversion compiler option and fix implicit conversions that mi… 

    …ght alter the value

Signed-off-by: Johannes Meyer <[email protected]>
    @meyerj
    meyerj committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    cf6c8c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. Fix expected exception type in TestDuration.conversions test case 

    Signed-off-by: Johannes Meyer <[email protected]>
    @meyerj
    meyerj committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    3628064 View commit details
    Browse the repository at this point in the history

  2. Fix usage of fixture class in some unit tests 

    ... by using gtest macro TEST_F() instead of TEST().

Signed-off-by: Johannes Meyer <[email protected]>
    @meyerj
    meyerj committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    683ac64 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Address PR comments and unify argument name clock_type in Time() cons… 

    …tructors

Signed-off-by: Johannes Meyer <[email protected]>
    @meyerj
    meyerj committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    f9cf569 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Add compiler option -Wno-sign-conversion to fix build with Clang on m… 

    …acOS

Signed-off-by: Johannes Meyer <[email protected]>
    @meyerj
    meyerj committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    f5fed09 View commit details
    Browse the repository at this point in the history