Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using constref signature of benchmark DoNotOptimize. #2238

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Stop using constref signature of benchmark DoNotOptimize. #2238

merged 2 commits into from
Jul 18, 2023

Commits on Jul 17, 2023

  1. Stop using constref signature of benchmark DoNotOptimize. 

    Newer versions of google benchmark (1.8.2 in my case) warn
that the compiler may optimize away the DoNotOptimize calls
when using the constref version.  Get away from that here
by explicitly *not* calling the constref version, casting
where necessary.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    9ded574 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Feedback from review. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    2af0448 View commit details
    Browse the repository at this point in the history