waitset -> wait_set #408
Merged
waitset -> wait_set #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
force-pushed
the
wait_set_two_words
branch
from
1e0a214
to
f42bb32
Compare
dhood
approved these changes
Nov 27, 2017
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* implement rcl_wait and rcl_take for rcl_event_t Signed-off-by: Miaofei <[email protected]> * address feedback regarding formatting issues Signed-off-by: Miaofei <[email protected]> * Remove dependency on sleep in test_events Signed-off-by: Ross Desmond <[email protected]> * update total max wait time for setting up publisher and subscriber to 10 seconds Signed-off-by: Miaofei <[email protected]> * Fix test_events for rmw_connext Signed-off-by: Ross Desmond <[email protected]> * Refactor out timed loop from tests to function Signed-off-by: Miaofei <[email protected]> * address additional feedback from pull request Signed-off-by: Miaofei <[email protected]> * update comment regarding difference between connext and opensplice Signed-off-by: Miaofei <[email protected]> * fix uncrustify issues Signed-off-by: Miaofei <[email protected]> * update test_events for compatibility with API changes Signed-off-by: Miaofei <[email protected]> * temporarily disable test_events for macOS Signed-off-by: Miaofei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to ros2/rmw#131