Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executor executes the tasks in FIFO order. #1304

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Executor executes the tasks in FIFO order. #1304

merged 2 commits into from
Jun 26, 2024

Conversation

fujitatomoya
Copy link
Collaborator

address #1303

@fujitatomoya fujitatomoya mentioned this pull request Jun 20, 2024
Closed
@fujitatomoya
Copy link
Collaborator Author

@sloretz @Barry-Xu-2018 can you take a look at this?

i am not sure if we can backport this to jazzy since it changes behavior. i believe user application should not rely on the execution order, but we cannot say there is no application relies on the current behavior with released distro.

fujitatomoya
fujitatomoya commented Jun 20, 2024
View reviewed changes
rclpy/rclpy/executors.py Outdated Show resolved Hide resolved
rclpy/test/test_executor.py Show resolved Hide resolved
@Barry-Xu-2018
Copy link
Contributor

LGTM

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/task-queue-in-fifo-order branch from 1aab5b8 to 1dc3054 Compare June 25, 2024 05:32
sloretz
sloretz approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree that this should not be backported

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Jun 25, 2024 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

https://ci.ros2.org/job/ci_linux-rhel/834/#showFailuresLink is unrelated.

@fujitatomoya fujitatomoya reopened this Jun 26, 2024
@fujitatomoya fujitatomoya merged commit 43198cb into rolling Jun 26, 2024
3 checks passed
@fujitatomoya
Copy link
Collaborator Author

Note: we will not backport this since it changes the execution order in task queue. even though this fixes the order into FIFO which is expected order, this would be surprising behavior change for some user application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @Barry-Xu-2018 @sloretz