-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executor executes the tasks in FIFO order. #1304
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
@sloretz @Barry-Xu-2018 can you take a look at this? i am not sure if we can backport this to jazzy since it changes behavior. i believe user application should not rely on the execution order, but we cannot say there is no application relies on the current behavior with released distro. |
LGTM |
Signed-off-by: Tomoya Fujita <[email protected]>
1aab5b8
to
1dc3054
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I agree that this should not be backported
Note: we will not backport this since it changes the execution order in task queue. even though this fixes the order into FIFO which is expected order, this would be surprising behavior change for some user application. |
address #1303