Fixes spin_until_future_complete removing node it didn't add (backport #1316) #1341
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Closes rclpy:#1313 Current if spin_unitl_future_complete is called inside a nodes callback it removes the node from the executor This results in any subsiquent waitables to never be checked by the node since the node is no longer in the executor This aims to fix that by only removing the node from the executor if it wasn't already present Signed-off-by: Jonathan Blixt <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 47346ef)
|
Why is the DCO check failing here? |
|
See https://github.com/ros2/rclpy/pull/1341/checks?check_run_id=29191298421
In my experience, this is caused by a mismatch between the sign-off name and the GitHub profile name. Sometimes when merging a commit, GitHub sets the commit author name to the GitHub profile name. The DCO check can be overridden by maintainers, though. |
|
Pulls: #1341
|
Closes #1313
Current if spin_unitl_future_complete is called inside a nodes callback it removes the node from the executor
This results in any subsiquent waitables to never be checked by the node since the node is no longer in the executor
This aims to fix that by only removing the node from the executor if it wasn't already present
This is an automatic backport of pull request #1316 done by Mergify.