Use @deprecated to mark deprecated APIs for type checkers. #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
InvincibleRMC
requested review from
sloretz and
adityapande-1995
as code owners
Signed-off-by: Michael Carlstrom <[email protected]>
sloretz
reviewed
Aug 30, 2024
| @@ -38,6 +38,7 @@ | |||
| <exec_depend>action_msgs</exec_depend> | |||
| <exec_depend>ament_index_python</exec_depend> | |||
| <exec_depend>builtin_interfaces</exec_depend> | |||
| <exec_depend>python3-typing-extensions</exec_depend> | |||
There was a problem hiding this comment.
This one seems like a problem as an rclpy dependency because it doesn't exist on RHEL , and RHEL is Tier 2 which means CI is expected to pass. Is there something else we can use?
There was a problem hiding this comment.
Hm that's strange. typing-extensions is a dependency of mypy which is a dependency of ament_mypy which is built by the ROS build farm.
There was a problem hiding this comment.
Hmm in rosdep it exist for rhel. https://github.com/ros/rosdistro/blob/master/rosdep/python.yaml#L9954
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clean up some typing imports to use typing_extensions.