-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @deprecated to mark deprecated APIs for type checkers. #1350
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
@@ -38,6 +38,7 @@ | |||
<exec_depend>action_msgs</exec_depend> | |||
<exec_depend>ament_index_python</exec_depend> | |||
<exec_depend>builtin_interfaces</exec_depend> | |||
<exec_depend>python3-typing-extensions</exec_depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems like a problem as an rclpy dependency because it doesn't exist on RHEL , and RHEL is Tier 2 which means CI is expected to pass. Is there something else we can use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm that's strange. typing-extensions
is a dependency of mypy which is a dependency of ament_mypy which is built by the ROS build farm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm in rosdep it exist for rhel. https://github.com/ros/rosdistro/blob/master/rosdep/python.yaml#L9954
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Also clean up some typing imports to use typing_extensions.