-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix load_parameter_dict_from_yaml test failure on windows #956
Conversation
Signed-off-by: Brian Chen <[email protected]>
Signed-off-by: Brian Chen <[email protected]>
Basically I believe that each PR should have complete fix w/o build break for maintenance. this could be problem when we do cherry-pick. @clalancette @Blast545 what do you think? |
I think that would be good too, especially since I forgot to hit squash merge on the original PR 😅. But reverting would involve rewriting history which wouldn't be good |
Not quite. We can do a I don't feel strongly about it either way, but I would strongly prefer that by end of day we either a) get the revert in, or b) get this fix in (I notice that it is failing all CI). |
I don't have any preference as well, @fujitatomoya maybe just do what you think is best? I passed in the wrong argument to CI, try these ones instead: |
@fujitatomoya I've created a revert PR at #958 and I will submit a new PR with the new feature & all the fixes included |
See discussion @ #956 Signed-off-by: Brian Chen <[email protected]>
Resolves windows test failure for
load_parameter_dict_from_yaml_file
caused by windows handling of tempfiles. (See: #945 (comment))I've also bundled in a small fix in this PR to change the default depth of
list_parameters
to the full depth instead of 1 which to me is a saner default.