Added directory and file utils to replace tinydir #218
Conversation
Signed-off-by: ahcorde <[email protected]>
|
Just a note that this shouldn't have a major documentation impact as |
The new API certainly needs test coverage. |
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
|
Added test coverage 98a64ec |
|
According with the comment of @mikaelarguedas in rcl ros2/rcl#605 (comment) this code probably makes no sense. @dirk-thomas should we close both PRs? |
|
| /// is the file a directory ? | ||
| int is_dir; | ||
| // information about the file | ||
| #ifndef _WIN32 |
There was a problem hiding this comment.
nitpick: these preprocessor directives are usually not indented.
| int error = closedir(dir->dir); | ||
| // The closedir() function returns 0 on success | ||
| if (error) { | ||
| #else |
There was a problem hiding this comment.
nitpick: this indent is weird too
| #else | ||
| // If the function succeeds, the return value is nonzero. | ||
| if (!FindClose(dir->dir)) { | ||
| #endif |
There was a problem hiding this comment.
GitHub is failing to render this, maybe that's the source of your uncrustify issue too?
| if (lstat( | ||
| #else | ||
| if (_tstat( | ||
| #endif |
There was a problem hiding this comment.
Actually, this stanza is likely the issue... I'd recommend using a #define for this function name if that's all that really is different.
If the API is not used anymore, yes, I think it should just be removed. |
This PR is part of the effort to reduce the number of dependencies in ROS 2. Tinydir is only used in RCL in one place to find a folder that match with a string.
I have created a new file
directory_and_file_reader.[hc]maybe I can include this code infilesystem.[hc].Signed-off-by: ahcorde [email protected]