Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RCUTILS_NO_FAULT_INJECTION() macro. #295

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Add RCUTILS_NO_FAULT_INJECTION() macro. #295

merged 2 commits into from
Oct 1, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Sep 30, 2020

Precisely what the title says. To ease fault injection pausing.

@hidmic hidmic requested a review from brawner September 30, 2020 20:11
@hidmic hidmic mentioned this pull request Sep 30, 2020
Merged
@hidmic
Fix bad variable name.
c9c33b2 
Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic
Copy link
Contributor Author

hidmic commented Sep 30, 2020 •
edited
Loading

CI up to rcutils, test_rmw_implementation, and rcl:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hidmic
Copy link
Contributor Author

hidmic commented Oct 1, 2020

CI again after ros2/rmw_fastrtps#458:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor Author

hidmic commented Oct 1, 2020

Alright, all green ! Going in !

@hidmic hidmic merged commit 58580e8 into master Oct 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/no-fault-macro branch October 1, 2020 22:30
ahcorde pushed a commit that referenced this pull request Oct 2, 2020
@hidmic @ahcorde
Add RCUTILS_NO_FAULT_INJECTION() macro. (#295)
2ff0f00 
Signed-off-by: Michel Hidalgo <[email protected]>
ahcorde pushed a commit that referenced this pull request Oct 6, 2020
@hidmic @ahcorde
Add RCUTILS_NO_FAULT_INJECTION() macro. (#295)
31645af 
Signed-off-by: Michel Hidalgo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brawner brawner brawner approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hidmic @brawner @fujitatomoya