Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding required structs and methods to get a list of publishers or subscribers with their respective qos #186

Merged
merged 31 commits into from
Jan 14, 2020
Merged

Adding required structs and methods to get a list of publishers or subscribers with their respective qos #186

merged 31 commits into from
Jan 14, 2020

Commits on Oct 25, 2019

  1. Added two structs: 

    	rmw_participant_qos_profile_t: stores the publisher or subscriber name and its respective qos profile
	rmw_participants_t           : represents a list of rmw_participants_qos_profile_t

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    cce521a View commit details
    Browse the repository at this point in the history

  2. Added two functions to retrieve the list of all subscribers and publi… 

    …shers to a topic, along with their respective qos profiles.

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    8fe5fd2 View commit details
    Browse the repository at this point in the history

  3. Allocator and free functions for rmw_participant_qos_profile 

    Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    69744dd View commit details
    Browse the repository at this point in the history

  4. Fixed code indentation issues 

    Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    20bedc2 View commit details
    Browse the repository at this point in the history

  5. Tests to rmw_participant_qos_profile_t_allocator 

    Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    94b27b3 View commit details
    Browse the repository at this point in the history

  6. Modified tests to avoid memory leak 

    Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    ed9651e View commit details
    Browse the repository at this point in the history

  7. - Updated rmw_participants_t to use rmw_participant_qos_profile_t * 

    instead of a generic pointer
- Updated tests to use the correct deallocator

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    5c5ccbf View commit details
    Browse the repository at this point in the history

  8. Changed rmw_participants_t to use a pointer to an array. 

    Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    06c5d4c View commit details
    Browse the repository at this point in the history

  9. PR rework after design changes 

    - Removed allocator and free for rmw_participant_qos_profile_t
- Added new structs to better represent required data
- Added functions to get publisher and subscriber info by topic
- Removed previously created tests for the allocator and free functions

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    a5e113b View commit details
    Browse the repository at this point in the history

  10. - Changed member variables from const type const to const type in 

    rmw_topic_info_t
- Change type of gid to const char *

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    1714008 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. - Added zero_init, check_zero, init_with_size and fini functions for 

    rmw_topic_info_array_t
- Added tests for the same

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    583687e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. - More informative comments 

    - Setters for allocating memory and copying strings for gid, topic_type,
node_name and node_namespace

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    91a5668 View commit details
    Browse the repository at this point in the history

  2. - Fixed warnings on deallocate by casting const char * to char * 

    - No longer returning error if info_array is not allocated memory in
fini

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    091988c View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Fixed code formatting issues 

    Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    ad84fb3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. - Using strncpy instead of strcpy 

    Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    9b22c98 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Using memcpy instead of strncpy to prevent warnings on Windows 

    Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    383e4a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2019

  1. - Comment modification to be more explicit. 

    - Changed topic_info* method signatures
- Moved topic_info_set* functions to a different file
- Tests for topic_info_set* functions
- Changed type of gid in rmw_topic_info_t to uint8_t[]
- Changed type of qos_profile in rmw_topic_info_t from pointer to
storing the structure.

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    5e0e27f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. - Fixed function comments 

    - Moved get_*_info_by_topic functions to a new file

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    1d9e1fe View commit details
    Browse the repository at this point in the history

  2. Using memcpy in topic_info_set_gid 

    Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    cbd91b3 View commit details
    Browse the repository at this point in the history

  3. Added init and fini functions for rmw_topic_info_t and tests for the 

    same.

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    e24e1f4 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. change c-strings under topic_info to be non-const 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    272a2dc View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. revert the change that removed const qualifiers 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    c00ad69 View commit details
    Browse the repository at this point in the history

  2. address PR comments 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    3e8f892 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. address PR comments 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    a1c35de View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. add rmw_qos_profile_unknown 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    747c4c9 View commit details
    Browse the repository at this point in the history

  2. use constant instead of literal for history depth 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    06bb093 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. address more PR comments 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    c82859b View commit details
    Browse the repository at this point in the history

  2. rename *topic_info* to *topic_endpoint_info* 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    702aef2 View commit details
    Browse the repository at this point in the history

  3. fix formatting 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    8ddb815 View commit details
    Browse the repository at this point in the history

  4. remove unused enum value from rmw_endpoint_type_t 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    6d9675a View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. fix clang compiler warnings 

    Signed-off-by: Miaofei <[email protected]>
    @mm318
    mm318 committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    2915b73 View commit details
    Browse the repository at this point in the history