Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods to retrieve matched counts on pub/sub #234

Merged
merged 7 commits into from
Nov 28, 2018
Merged

Methods to retrieve matched counts on pub/sub #234

merged 7 commits into from
Nov 28, 2018

Commits on Nov 28, 2018

  1. Methods to retrieve matched counts on pub/sub.

    @mjcarroll
    mjcarroll committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    7e58287 View commit details
    Browse the repository at this point in the history

  2. Address reviewer feedback.

    @mjcarroll
    mjcarroll committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    75f48e3 View commit details
    Browse the repository at this point in the history

  3. Fix missing publisher.

    @mjcarroll
    mjcarroll committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    f74b2b3 View commit details
    Browse the repository at this point in the history

  4. Fix some potential leaks.

    @mjcarroll
    mjcarroll committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    47b1a52 View commit details
    Browse the repository at this point in the history

  5. Replace with CHECK_ARGUMENT_FOR_NULL

    @mjcarroll
    mjcarroll committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    38575cb View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-Authored-By: mjcarroll <[email protected]>
    @jacobperron @mjcarroll
    jacobperron and mjcarroll committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    311275a View commit details
    Browse the repository at this point in the history

  7. Address reviewer feedback.

    @mjcarroll
    mjcarroll committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    6074f18 View commit details
    Browse the repository at this point in the history