Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new functions which can be used to get rmw_qos_profile_t from WriterQos and ReaderQos #328

Merged
merged 4 commits into from
Oct 14, 2019
Merged

Added new functions which can be used to get rmw_qos_profile_t from WriterQos and ReaderQos #328

merged 4 commits into from
Oct 14, 2019

Commits on Oct 9, 2019

  1. - Added new functions to qos.hpp which can be used to get 

    rmw_qos_profile_t from WriterQos and ReaderQos
- Refactored dds_qos_to_rmw to re-use these new functions
- Added tests for dds_qos_to_rmw

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    407a8ba View commit details
    Browse the repository at this point in the history

  2. PR Refactor 

    - Took off dds_qos_policy_to_rmw_qos from qos.h to a new header inside
src called qos_converter
- renamed test file to be more representative of the function it is
testing
- refactored test code to use Value-Parameterised Gtests

Note: Ran colcon test --package-select rmw_fastrtps_shared_cpp without any
errors or failures

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    cbe44c4 View commit details
    Browse the repository at this point in the history

  3. PR Refactor 

    - Removed qos_converter.cpp and moved template function implementation
to qos_converter.hpp

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    a54f55b View commit details
    Browse the repository at this point in the history

  4. - Changes to handle rename of function dds_qos_to_rmw_qos 

    - Renamed test file name to test_dds_attributes_to_qos.cpp
- Changed function name in test to dds_attributes_to_qos.cpp
- The refactored (new) function is now called dds_qos_to_rmw_qos

Note: colcon test --package-select rmw_fastrtps_shared_cpp runs without any
errors or failures

Signed-off-by: Jaison Titus <[email protected]>
    @jaisontj
    jaisontj committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    05a57a6 View commit details
    Browse the repository at this point in the history