Add tests bad type_support implementation #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lobotuerk <[email protected]>
hidmic
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
LGTM pending green CI
Thanks for the extra lines @Lobotuerk !
| @@ -150,6 +150,14 @@ TEST_F(CLASSNAME(TestSubscription, RMW_IMPLEMENTATION), create_with_bad_argument | |||
| EXPECT_EQ(nullptr, sub); | |||
| rmw_reset_error(); | |||
|
|
|||
| rosidl_message_type_support_t * non_implementation_ts = const_cast<rosidl_message_type_support_t *>(ts); | |||
There was a problem hiding this comment.
@Lobotuerk nit:
Suggested change
| rosidl_message_type_support_t * non_implementation_ts = const_cast<rosidl_message_type_support_t *>(ts); | |
| rosidl_message_type_support_t * non_const_ts = const_cast<rosidl_message_type_support_t *>(ts); |
Same elsewhere.
Signed-off-by: lobotuerk <[email protected]>
Signed-off-by: lobotuerk <[email protected]>
Signed-off-by: lobotuerk <[email protected]>
|
CI up
|
hidmic
reviewed
Sep 30, 2020
Signed-off-by: Michel Hidalgo <[email protected]>
|
Another CI run:
|
|
CI again after ros2/rmw_fastrtps#458:
|
|
Alright, all green ! Thanks @Lobotuerk ! |
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: lobotuerk <[email protected]> Co-authored-by: Michel Hidalgo <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 21, 2020
Signed-off-by: lobotuerk <[email protected]> Co-authored-by: Michel Hidalgo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests should add 10 lines of coverage to
rmw_fastrtps_cppSigned-off-by: lobotuerk [email protected]