Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functions to get qos policies for publishers and subscribers to a topic #72

Merged
merged 5 commits into from
Jan 14, 2020

Conversation

jaisontj
Copy link
Contributor

@jaisontj jaisontj commented Oct 4, 2019

As a part of implementing this feature. The RMW layer needs to expose apis to retrieve a list of publishers and subscribers along with their QoS policies for a given topic.

  • rmw_get_qos_for_subscribers to get the qos policies for subscribers to
    a topic
  • rmw_get_qos_for_publishers to a get the qos policies for publishers to
    a topic

Merge this PR after this is approved as the new functions depend on the newly created structure rmw_participants_t

@jaisontj
Copy link
Contributor Author

jaisontj commented Oct 4, 2019

The build will fail until this is approved.

@jaisontj jaisontj force-pushed the jaisontj/get_qos_for_participants branch from ad83a29 to 6282daa Compare October 16, 2019 16:41
@jaisontj jaisontj marked this pull request as ready for review October 16, 2019 17:32
@jaisontj
Copy link
Contributor Author

@ivanpauno Related to this

- rmw_get_publishers_info_by_topic to get the qos policies for
publishers to a topic
- rmw_get_subscriptions_info_by_topic to a get the qos policies for
subscriptions to a topic

Signed-off-by: Jaison Titus <[email protected]>
rmw_get_subscriptions_info_by_topic to RMW_RET_UNSUPPORTED.
- Added a rmw_reset_error_msg() after GET_SYMBOL() to above two
functions to prevent a display of "Error message being replaced. Called
rcultils_reset_error() after error handling".

Signed-off-by: Jaison Titus <[email protected]>
@jaisontj jaisontj force-pushed the jaisontj/get_qos_for_participants branch from 6282daa to 6dd0abf Compare November 15, 2019 01:48
Signed-off-by: Jaison Titus <[email protected]>
@jaisontj jaisontj force-pushed the jaisontj/get_qos_for_participants branch from bcb3e99 to 9879583 Compare November 22, 2019 16:57
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@piraka9011
Copy link

@hidmic @ivanpauno lets get this merged please :)

@ivanpauno
Copy link
Member

ivanpauno commented Jan 9, 2020

@hidmic @ivanpauno lets get this merged please :)

I'm sorry, but I don't see any value in merging this until the comments in rmw and downstream PRs (rmw_fastrtps, etc) are addressed. I understand that the review process is long, but that has to be addressed first.

@piraka9011
Copy link

piraka9011 commented Jan 9, 2020

I don't see any value in merging this until the comments in rmw and downstream PRs (rmw_fastrtps, etc) are addressed.
When that happens, I will merge them.

Whoops, jumped the boat early on this one, thought it was an earlier PR. My bad!!

@ivanpauno ivanpauno merged commit f3def1a into ros2:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants