This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Combine package name with message namespace in type support struct #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <[email protected]>
dirk-thomas
reviewed
May 6, 2019
| type_namespace = std::regex_replace(type_namespace, std::regex("::"), "/"); | ||
| size_t start = substring_position + substring.size(); | ||
| std::string type_name = dds_type_string.substr(start, dds_type_string.length() - 1 - start); | ||
| return type_namespace + type_name; |
There was a problem hiding this comment.
Inverting the logic makes the diff more difficult to review. What was the reason to do so?
There was a problem hiding this comment.
Consistency. The logic now matches the other rmw implementations. I can revert it or break it into two commits if you prefer.
There was a problem hiding this comment.
No need it - the change looks good. I just wanted to check.
dirk-thomas
approved these changes
May 6, 2019
Signed-off-by: Jacob Perron <[email protected]>
2 tasks
Signed-off-by: Jacob Perron <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/ros2#677