Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread-safe access to SubscriptionData #288

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Thread-safe access to SubscriptionData #288

merged 6 commits into from
Oct 7, 2024

Commits on Oct 4, 2024

  1. Make SubscriptionData thread safe 

    Signed-off-by: Yadunund <[email protected]>
    @Yadunund
    Yadunund committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8365f54 View commit details
    Browse the repository at this point in the history

  2. Set subscription handle to SubScriptionData raw ptr due to rmw_wait l… 

    …imitation

Signed-off-by: Yadunund <[email protected]>
    @Yadunund
    Yadunund committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    709899a View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Signed-off-by: Yadunund <[email protected]>
    @Yadunund
    Yadunund committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a4d985e View commit details
    Browse the repository at this point in the history

  4. Safely shutdown SubscriptionData even if make() fails and cleanup todo 

    Signed-off-by: Yadunund <[email protected]>
    @Yadunund
    Yadunund committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f8ea0c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Undeclare z_sub only if z_check passes 

    Signed-off-by: Yadunund <[email protected]>
    @Yadunund
    Yadunund committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2bd7e13 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: yadunund <[email protected]>
    @Yadunund @ahcorde
    Yadunund and ahcorde authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f66a860 View commit details
    Browse the repository at this point in the history