-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add explanation for ROS_DISABLE_LOANED_MESSAGES
.
#2282
add explanation for ROS_DISABLE_LOANED_MESSAGES
.
#2282
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
@wjwwood @clalancette requesting review. |
@wjwwood @clalancette requesting review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this information should be in this particular tutorial. This is the very first beginner tutorial, and we don't want to overload people with a bunch of advanced information about configuring their libraries.
I would suggest that this belongs either in one of the more advanced tutorials or in a How-To Guide.
I agree this seems like we're hijacking this beginner tutorial in order to turn it into a reference for all the environment variables that can be used to configure ros 2, when we should just have a reference page for that (not a tutorial). Do we already have such a page? |
I could see putting a new page in either "How-To-Guides", something like "how to disable loaned messages", or in "Concepts", something like "loaned messages" which describes generally what they are and as part of that how to use this environment variable to control them. Or we could have a reference page with all the environment variables you could use with ros 2, where one of them is this env var, but I don't know where that would live. @clalancette what do you think? |
thanks for the comment. I understand this is not really tutorial... 😅
sounds good to me. |
Yeah, that works for me too. I think it would be nice to have a page showing all of the possible environment variables that can be used with ROS 2, but I think that would be a long list, and is out-of-scope for this particular change. |
dd3d15b
to
004d09f
Compare
Signed-off-by: Tomoya Fujita <[email protected]>
004d09f
to
1f8ca65
Compare
@clalancette @wjwwood could you take a look again? |
this is last one related to |
Signed-off-by: Tomoya.Fujita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, thanks.
document for ros2/rcl#949
Signed-off-by: Tomoya Fujita [email protected]