Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2 topic echo Crashes when using opensplice #110

Closed
sloretz opened this issue Jun 22, 2018 · 5 comments
Closed

ros2 topic echo Crashes when using opensplice #110

sloretz opened this issue Jun 22, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@sloretz
Copy link
Contributor

sloretz commented Jun 22, 2018

Bug report

Required Info:

Steps to reproduce issue

REM Make sure daemon is using opensplice
set RMW_IMPLEMENTATION=rmw_opensplice_cpp
ros2 daemon stop
ros2 daemon start
ros2 run demo_nodes_cpp talker

REM in another terminal
ros2 topic echo chatter

Expected behavior

Messages would be echo'd on second terminal

Actual behavior

>ros2 topic echo chatter
========================================================================================
Context     : DDS::WaitSet::detach_condition
Date        : Fri Jun 22 16:01:21 Pacific Daylight Time 2018
Node        : DESKTOP-S5KSNBT
Process     : python.exe <4384>
Thread      : 1544
Internals   : WaitSet.cpp/456/6.7.180404OSS/5926d257/5926d257/-1
----------------------------------------------------------------------------------------
Report      : Precondition not met: This ReadCondition is being deleted.
Internals   : DDS::OpenSplice::ReadCondition::wlReq_detachFromWaitset/ReadCondition.cpp/176/4/1529708482.015405000
Failed to wait on wait set: failed to detach guard condition, at C:\J\workspace\packaging_windows\ws\src\ros2\rmw_opensplice\rmw_opensplice_cpp\src\rmw_wait.cpp:282, at C:\J\workspace\packaging_windows\ws\src\ros2\rcl\rcl\src\rcl\wait.c:647

Additional information

@sloretz sloretz added the bug Something isn't working label Jun 22, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Jun 22, 2018

Probably duplicate of #107

@dirk-thomas
Copy link
Member

It isn't a duplicate since the error happens at a different condition. Please try to update ros2/rmw_opensplice#235 to add the same handling for this case (and probably also for all other condition).

@mikaelarguedas
Copy link
Member

Similar to #107, the workaround from ros2/rmw_opensplice#235 may apply to this bug as well

dirk-thomas added a commit to ros2/rmw_opensplice that referenced this issue Jun 23, 2018
dirk-thomas added a commit to ros2/rmw_opensplice that referenced this issue Jun 23, 2018
dirk-thomas added a commit to ros2/rmw_opensplice that referenced this issue Jun 24, 2018
* accept precondition-not-met when detaching read condition

* same patch for ros2/ros2cli#110
@sloretz
Copy link
Contributor Author

sloretz commented Jun 26, 2018

Works fine from master using ubuntu bionic. I don't have a from-source setup for windows at the moment to check if it is truly fixed.

@dirk-thomas
Copy link
Member

Closing since it has been addressed by ros2/rmw_opensplice#235. The remaining warning is ticketed in ros2/rmw_opensplice#237.

esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
Also added tests for RegisterEventHandler and UnregisterEventHandler actions.
esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
esteve pushed a commit to esteve/ros2cli that referenced this issue Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants