Skip to content

Commit

Permalink
Standardize the binary job timeouts at 150 minutes. (#311)
Browse files Browse the repository at this point in the history
Currently, Ubuntu amd64 and RHEL amd64 binary jobs are
at 120 minutes, while Ubuntu aarch64 binary jobs are at 720
minutes.  That latter timeout is probably a legacy of when
the aarch64 jobs used qemu to build.

This controversial PR changes all of them to 150 minutes.
To be clear, that is a 30 minute *increase* in the case of
amd64, and a 570 minute decrease in the case of aarch64.

My reasoning here is as follows:
1.  We know we have jobs on the buildfarm that "sometimes"
complete in their current 120 minute timeslot.  When they
run out of time, they usually would have finished in the
next 10 minutes.
2.  aarch64 jobs have been set to 720 minutes for a while,
but we don't see a huge number of binary jobs taking longer
than 150 minutes there.  So I think our risk of lots of
packages suddenly increasing their time is limited.
3.  This should materially improve the experience of the ROS
Bosses, as there will be fewer jobs they have to run "by hand"
to have regression-free syncs.

Signed-off-by: Chris Lalancette <[email protected]>
  • Loading branch information
clalancette authored Aug 9, 2024
1 parent 00dc375 commit 2e5343f
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion humble/release-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build_environment_variables:
RTI_NC_LICENSE_ACCEPTED: 'yes'

jenkins_binary_job_priority: 85
jenkins_binary_job_timeout: 120
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 75
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion humble/release-rhel-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build_environment_variables:
RPM_BUILD_NCPUS: '1'

jenkins_binary_job_priority: 85
jenkins_binary_job_timeout: 120
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 75
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion humble/release-ubuntu-arm64-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
abi_incompatibility_assumed: true
jenkins_binary_job_label: buildagent_arm64 || humble_binarydeb_ujv8
jenkins_binary_job_priority: 85
jenkins_binary_job_timeout: 720
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 75
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion iron/release-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build_environment_variables:
RTI_NC_LICENSE_ACCEPTED: 'yes'

jenkins_binary_job_priority: 84
jenkins_binary_job_timeout: 120
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 74
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion iron/release-rhel-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build_environment_variables:
RPM_BUILD_NCPUS: '1'

jenkins_binary_job_priority: 84
jenkins_binary_job_timeout: 120
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 74
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion iron/release-ubuntu-arm64-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
abi_incompatibility_assumed: true
jenkins_binary_job_label: buildagent_arm64 || iron_binarydeb_ujv8
jenkins_binary_job_priority: 84
jenkins_binary_job_timeout: 720
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 74
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion jazzy/release-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build_environment_variables:
RTI_NC_LICENSE_ACCEPTED: 'yes'

jenkins_binary_job_priority: 80
jenkins_binary_job_timeout: 120
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 70
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion jazzy/release-rhel-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build_environment_variables:
RPM_BUILD_NCPUS: '1'

jenkins_binary_job_priority: 80
jenkins_binary_job_timeout: 120
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 70
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion jazzy/release-ubuntu-arm64-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
abi_incompatibility_assumed: true
jenkins_binary_job_label: buildagent_arm64 || jazzy_binarydeb_unv8
jenkins_binary_job_priority: 80
jenkins_binary_job_timeout: 720
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 70
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion rolling/release-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build_environment_variables:
RTI_NC_LICENSE_ACCEPTED: 'yes'

jenkins_binary_job_priority: 80
jenkins_binary_job_timeout: 120
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 70
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion rolling/release-rhel-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build_environment_variables:
RPM_BUILD_NCPUS: '1'

jenkins_binary_job_priority: 80
jenkins_binary_job_timeout: 120
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 70
jenkins_source_job_timeout: 30
notifications:
Expand Down
2 changes: 1 addition & 1 deletion rolling/release-ubuntu-arm64-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
abi_incompatibility_assumed: true
jenkins_binary_job_label: buildagent_arm64 || rolling_binarydeb_unv8
jenkins_binary_job_priority: 80
jenkins_binary_job_timeout: 720
jenkins_binary_job_timeout: 150
jenkins_source_job_priority: 70
jenkins_source_job_timeout: 30
notifications:
Expand Down

0 comments on commit 2e5343f

Please sign in to comment.