Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange location of recorder and player executables #1736

Open
Timple opened this issue Jun 27, 2024 · 4 comments · May be fixed by #1603
Open

Strange location of recorder and player executables #1736

Timple opened this issue Jun 27, 2024 · 4 comments · May be fixed by #1603
Labels
bug Something isn't working

Comments

@Timple
Copy link

Timple commented Jun 27, 2024

Description

We can run the recorder as a node by:

ros2 run rosbag2_transport recorder

This cannot be guessed but has to be reverse engineered from code.

Expected Behavior

ros2 run rosbag2 recorder

or

ros2 run ros2bag recorder

Actual Behavior

Type ros2 run rosbag2 and try tab-complete, this fails

To Reproduce

These templates are getting rediculous.

System

Jazzy

Additional context

Yes, there the commanline cli of course. But in launchfiles this:

<node name="rosbag_operational" pkg="rosbag2" exec="recorder" />

Looks much better than

<executable cmd="ros2 bag record --node-name rosbag_operational"/>

As it's consistent with other stuff, better passes ros arguments etc. Also node renaming and remapping is much better.

@Timple Timple added the bug Something isn't working label Jun 27, 2024
@roncapat
Copy link
Contributor

Hi @Timple, see #1510 (comment) for previous discussions on this matter.

@roncapat
Copy link
Contributor

And here is the draft PR #1603

@Timple
Copy link
Author

Timple commented Jun 27, 2024

Great!

Do you want me to keep it open as placeholder? Or feel free to close it

@roncapat
Copy link
Contributor

I linked resolution of my PR to this issue, I would leave this open.
Could you check the PR and provide feedback, if any?
So I may try to find some time to complete it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants