-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent using message compression mode with mcap storage #1782
Prevent using message compression mode with mcap storage #1782
Conversation
8be5d42
to
fdf998d
Compare
@MichaelOrlov since #1705 seems to have gone dead - I've re-created the PR here with the changes and passing lint. |
I don't understand the DCO check - if that's something I am supposed to do or if a maintainer does the sign-off. |
@defunctzombie The DCO is a sort of signature from the committer claiming that the committer is the author of the changes. |
@defunctzombie Could you please retarget your branch to the rolling branch? |
These changes are specifically against humble branch because the rolling branch has a completely different approach. I did what the original PR did - was that not the right thing to do? |
Signed-off-by: Roman Shtylman <[email protected]>
fdf998d
to
107c035
Compare
@defunctzombie Sorry, I've already forgotten a point about the initial PR purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI.
Pulls: #1782 |
MCAP does not support per-message compression. To prevent users from falling into the trap of recording such files, this change throws an error if per-message compression is used with the mcap storage plugin.
This is a backport of the same behavior present in iron onwards: (https://github.com/ros2/rosbag2/blob/iron/rosbag2_storage_mcap/src/mcap_storage.cpp#L821).
Continuation of #1705 which has gone dead.