Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zstd lib #1784

Closed
wants to merge 1 commit into from
Closed

Update zstd lib #1784

wants to merge 1 commit into from

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 requested a review from a team as a code owner August 10, 2024 06:58
@mosfet80 mosfet80 requested review from emersonknapp and james-rms and removed request for a team August 10, 2024 06:58
fujitatomoya
fujitatomoya approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

clalancette
clalancette requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in other places, I'd prefer to keep this the same as the version installed in Ubuntu 24.04, which is v1.5.5. So I don't think we should take this.

@MichaelOrlov
Copy link
Contributor

  • Closing as will not be merged, because we want to use the same version as in the Ubuntu 24.04 distro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette requested changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros2/tooling-reviewers

@james-rms james-rms Awaiting requested review from james-rms james-rms is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mosfet80 @MichaelOrlov @clalancette @fujitatomoya