-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix same named types overriding typesources #759
Conversation
Signed-off-by: Emerson Knapp <[email protected]>
@@ -34,6 +34,7 @@ if(BUILD_TESTING) | |||
${test_interface_files_ACTION_FILES} | |||
${test_interface_files_MSG_FILES} | |||
${test_interface_files_SRV_FILES} | |||
msg/BasicIdl.idl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be totally clear, this is an unrelated test, correct? I'm actually fine with adding it in here for testing purposes, but I just want to make sure I'm not missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to make extra sure, here in rosidl
repo, that the new changes didn't break anything for .idl
files, which are handled slightly differently as they don't go through rosidl_adapter
. The intention for this extra file is to serve that purpose, since there were not yet any .idl
files being tested by this package.
Signed-off-by: Emerson Knapp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with green CI.
Pulls: #759 |
@Mergifyio backport iron |
✅ Backports have been created
|
* Fix same named types overriding typesources Signed-off-by: Emerson Knapp <[email protected]> (cherry picked from commit 89c6713)
When two interface types in the same package had the same name stem (e.g.
msg/Empty.msg
andsrv/Empty.srv
), both types would receive the sameTypeSource
s in their generated description. Can be considered undefined behavior, but it's processed alphabetically so themsg
consistently received thesrv
sources.This fixes it, adds a regression test, and adds a new basic test for
.idl
files just to make sure that continues to work OK.Bug exists in Iron, this would need to be backported.