Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link legacy diff groups for git.vim and diff.vim syntax #42

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Link legacy diff groups for git.vim and diff.vim syntax #42

merged 1 commit into from
Dec 3, 2021

Conversation

chillax
Copy link
Contributor

@chillax chillax commented Dec 3, 2021

Diff output is missing proper colors when using e.g. fugitive.vim or when using neovim as $GIT_EDITOR. The built-in git.vim and diff.vim syntaxes use legacy highlight groups diffAdded, diffRemoved and diffChanged.

PR solves the issue by linking the legacy groups to the newer ones. Solution copied from similar issue in nord-vim.

Examples using fugitive.vim

Before
Screen Shot 2021-12-03 at 9 44 40

After
Screen Shot 2021-12-03 at 9 45 13

Fixes missing diff coloring when using the internal `git.vim` and `diff.vim` syntaxes
@mvllow mvllow merged commit 7bd39af into rose-pine:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants