Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to preview branch #71

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix link to preview branch #71

merged 1 commit into from
Dec 18, 2023

Conversation

netomi
Copy link
Contributor

@netomi netomi commented Dec 18, 2023

When appending the message to the pull request after deploying the preview, the link to the branch is wrong as it uses the wrong repo. Instead of deployrepo the repo of the pull request is used.

When appending the message to the pull request after deploying the preview, the link to the branch is wrong as it uses the wrong repo. Instead of deployrepo the repo of the pull request is used.
@netomi
Copy link
Contributor Author

netomi commented Dec 18, 2023

Here is an example of a wrong link: eclipse-langium/langium-website#212

In this setup we deploy previews from the eclipse-langium/langium-website to the eclipse-langium/langium-previews repo

The link goes to langium-website instead of langium-previews

@rossjrw rossjrw added the bug Something isn't working label Dec 18, 2023
@rossjrw
Copy link
Owner

rossjrw commented Dec 18, 2023

Resolves #50

Thanks for the contribution @netomi!

@rossjrw rossjrw merged commit 7df1ee4 into rossjrw:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants