magit-diff-whitespace-warning is invisible

[luispauloml]

magit-diff-whitespace-warning is set to nano-default which makes it invisible against the background in which it is intended to appear.

[rougier]

Thanks for the report. We could use 'nano-faded' or 'highlight' instead, what do you think?

[luispauloml]

Several magit-diff faces and magit-section-highlight, which are the backgrounds on which magit-diff-whitespace-warning appears, already inherit from highlight, thus this change would render it invisible again.

nano-theme/nano-theme.el

Lines 1332 to 1342 in 06d7c94

	'(magit-blame-highlight ((t (:inherit (highlight)))))
	'(magit-diff-added-highlight ((t (:inherit (highlight nano-salient nano-strong)))))
	'(magit-diff-base-highlight ((t (:inherit (highlight)))))
	'(magit-diff-context-highlight ((t (:inherit (highlight nano-faded)))))
	'(magit-diff-file-heading-highlight ((t (:inherit (highlight nano-strong)))))
	'(magit-diff-hunk-heading-highlight ((t (:inherit (nano-default)))))
	'(magit-diff-our-highlight ((t (:inherit (highlight)))))
	'(magit-diff-removed-highlight ((t (:inherit (highlight nano-popout nano-strong)))))
	'(magit-diff-revision-summary-highlight ((t (:inherit ()))))
	'(magit-diff-their-highlight ((t (:inherit (highlight)))))
	'(magit-section-highlight ((t (:inherit (highlight)))))

As for nano-faded, it wouldn't work because it does not change the background, so it would have to be nano-faded-i. The result looks good on nano-dark, but I think it is too dark for nano-light, which is the one I use:

If it would change to nano-faded-i, I would still keep using trailing-whitespace in nano-light.

In fact, I liked the result for both themes, as seen in opening of this issue, so removing customization of magit-diff-whitespace-warning from nano-theme in order for it to keep being trailing-whitespace is my suggestion for both themes

[rougier]

Thanks. I've pushed a fix (using nano-subtle)