Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable roundcube shell scripts to be directly executed #238

Merged
merged 2 commits into from
May 21, 2024

Conversation

lukasmu
Copy link
Contributor

@lukasmu lukasmu commented Jan 30, 2024

In my Kubernetes cluster I want to define a CronJob resource for periodic database cleanup as described here.

Ideally, I would like to do this by passing "bin/cleandb.sh" as argument to the entrypoint. See example in the commits.
Currently, this does not work since roundcube is not been copied to the docroot when the first argument passed to the entrypoint does not start with apache2 or php-fpm.

So I propose to extend the condition in all variants of the entrypoint script.

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomascube could we have this one?

@thomascube
Copy link
Member

Seems fair enough.

Although the cleanup cron job could also open a terminal into a running Roundcube pod and execute the cleanup command there. However, the changes makes sense to me.

@thomascube thomascube merged commit b6c9f5d into roundcube:master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants