Test #17
Closed
Test #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
force-pushed
the
cargo-deny-test
branch
10 times, most recently
from
73d4d9d
to
afefc4d
Compare
rparrett
force-pushed
the
cargo-deny-test
branch
from
afefc4d
to
6d75939
Compare
mockersf
reviewed
Feb 21, 2024
.github/workflows/dependencies.yml
Outdated
| run: cargo update | ||
| - name: Check for banned and duplicated dependencies (PR) | ||
| run: | | ||
| #!/bin/bash |
There was a problem hiding this comment.
oops, artifact of local testing
mockersf
reviewed
Feb 21, 2024
.github/workflows/dependencies.yml
Outdated
| - name: Check for banned and duplicated dependencies (base) | ||
| run: | | ||
| set -o history | ||
| OUT_FILE=/tmp/deny-bans-base |
There was a problem hiding this comment.
could you put the two OUT_FILE vars in an env: at the start of the job with different names?
|
I really wanted to find a convenient way to avoid repeating without getting into a nightmare of escaping quotes and stuff but ultimately failed |
|
I think you could have a "tooling" step in the job that would output the jq filter to a script, and reuse it in both steps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test comparing to merge base when doing cargo deny checks