bug(plugin): signal end of startup for genesis cluster if parent slot 0 seen #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanatid
approved these changes
Oct 17, 2023
|
Thanks @vovkman! |
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit 05d09b7)
fanatid
pushed a commit
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit 05d09b7)
fanatid
pushed a commit
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit 05d09b7) Co-authored-by: Liam Vovk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if plugin run on genesis of network,
notify_end_of_startupwill not be triggered. Slot 0 will not come throughupdate_slot_statusso the earliest signal is parent slot 0