reposync: Implement --safe-write-path option (RhBug:1898089) #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
force-pushed
the
mblaha/reposync-relative
branch
from
fd44208
to
1b1cb81
Compare
|
it's working! +1 for move out of Draft! |
jan-kolarik
reviewed
Apr 20, 2023
By default reposync is not allowed to write files outside of repository download path (by default ./<repo id>). But there are some repositories that store packages using relative parent paths (e.g. ../packages-store/f/foo.rpm). This patch introduces new --safe-write-path option that can override this limitation and set a root directory that is considered safe for writing. For example `dnf reposync --repoid=the_repo --safe-write-path=.` will allow reposync to write files not only to `./the_repo` directory but also to current working directory itself. = changelog = msg: With --safe-write-path option reposync can download repositories with relative package locations (like ../package-store/f/foo.rpm) type: enhancement resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1898089
m-blaha
force-pushed
the
mblaha/reposync-relative
branch
from
1b1cb81
to
ab6e7e9
Compare
jan-kolarik
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default reposync is not allowed to write files outside of repository download path (by default ./). But there are some repositories that store packages using relative parent paths (e.g. ../packages-store/f/foo.rpm).
This patch introduces new --safe-write-path option that can override this limitation and set a root directory that is considered safe for writing.
For example
dnf reposync --repoid=the_repo --safe-write-path=.will allow reposync to write files not only to./the_repodirectory but also to current working directory itself.= changelog =
msg: With --safe-write-path option reposync can download repositories with relative package locations (like ../package-store/f/foo.rpm)
type: enhancement
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1898089