Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loongarch support for dnf #1805

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

zhangwenlong8911
Copy link
Contributor

Signed-off-by: Zhang Wenlong [email protected]

@pep8speaks
Copy link

pep8speaks commented Dec 24, 2021

Hello @zhangwenlong8911! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-17 01:52:18 UTC

@zhangwenlong8911
Copy link
Contributor Author

Thank you very much for your review, I modified the code according to your suggestions

@dmach
Copy link

dmach commented Jan 14, 2022

Hi, this pull request adds loongarch32, but that doesn't seem to be part of other pull requests (rpm-software-management/rpm#1872 and rpm-software-management/libdnf#1402). Is it on purpose? Otherwise it would be good to add the same architectures to all places consistently.

Signed-off-by: Wenlong Zhang <[email protected]>
@zhangwenlong8911
Copy link
Contributor Author

Hi, this pull request adds loongarch32, but that doesn't seem to be part of other pull requests (rpm-software-management/rpm#1872 and rpm-software-management/libdnf#1402). Is it on purpose? Otherwise it would be good to add the same architectures to all places consistently.

loongarch32 is mainly used for embedded, loongarch64 has met the requirements, loongarchgarch32 should be deleted

@j-mracek
Copy link
Contributor

j-mracek commented Apr 7, 2022

Because related PR in RPM and LIBDNF was merged we can also merge it. Thank you very much for contribution.

@j-mracek j-mracek merged commit 96b08be into rpm-software-management:master Apr 7, 2022
@j-mracek j-mracek self-assigned this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants