Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittests that relied on checksum being at the end of solvfiles #1816

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Mar 1, 2022

No description provided.

@pep8speaks
Copy link

pep8speaks commented Mar 1, 2022

Hello @kontura! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-01 11:47:46 UTC

@kontura kontura force-pushed the checksum_at_end_of_solv_test_fix branch from e2ff4cf to 82935fa Compare March 1, 2022 11:47
@lukash
Copy link
Contributor

lukash commented Mar 17, 2022

It's not very pretty with using an unrelated repo .solv file to simulate checksum mismatch, but I guess it's good enough for dnf 4.

@kontura
Copy link
Contributor Author

kontura commented Mar 21, 2022

Alternatively we could add another new generated repo or edit the solvfile at a hard coded position by hand.
Using the already present drpm repo seemed like the lesser evil to me.

@lukash
Copy link
Contributor

lukash commented Mar 23, 2022

Let's keep it this way, should be good enough.

@lukash lukash merged commit 71e435f into rpm-software-management:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants