repoquery: Allow uppercased query tags #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before v4.15.0, query tags could be specified as both uppercased or lowercased. As part of commit e50488b ("repoquery: Properly sanitize queryformat strings"), this was (I believe) unintentionally changed to only support the lowercase variant. Although the documented supported tags are lowercase (as printed by `dnf repoquery --querytags`), it's clear that the intention here is to mirror rpm's query tags APIs. Confusingly, the canonical tag names for the latter are uppercased (as printed by `rpm --querytags`), though the lowercase variants are still supported. Let's restore support for uppercased query tags to match rpm more closely and unbreak anyone who assumed this was officially supported.
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Apr 14, 2023
Uppercase query tags broke in dnf v4.15.0. There is an upstream PR[[1]] to track restoring support for them, but since the canonical tag names are lowercase, switch to that. Fixes coreos/rpm-ostree#4368 [1]: rpm-software-management/dnf#1922
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Apr 14, 2023
Uppercase query tags broke in dnf v4.15.0. There is an upstream PR[[1]] to track restoring support for them, but since the canonical tag names are lowercase, switch to that. Fixes coreos/rpm-ostree#4368. [1]: rpm-software-management/dnf#1922
This was referenced Apr 14, 2023
|
This technically also allows e.g. |
|
Hey, that was my todo task for Monday! 😃 Thanks for that, I will do the review. |
gotmax23
approved these changes
Apr 14, 2023
cgwalters
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Apr 17, 2023
Uppercase query tags broke in dnf v4.15.0. There is an upstream PR[[1]] to track restoring support for them, but since the canonical tag names are lowercase, switch to that. Fixes coreos/rpm-ostree#4368. [1]: rpm-software-management/dnf#1922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before v4.15.0, query tags could be specified as both uppercased or lowercased. As part of commit e50488b ("repoquery: Properly sanitize queryformat strings"), this was (I believe) unintentionally changed to only support the lowercase variant.
Although the documented supported tags are lowercase (as printed by
dnf repoquery --querytags), it's clear that the intention here is to mirror rpm's query tags APIs. Confusingly, the canonical tag names for the latter are uppercased (as printed byrpm --querytags), though the lowercase variants are still supported.Let's restore support for uppercased query tags to match rpm more closely and unbreak anyone who assumed this was officially supported.