automatic: Return an error when transaction fails (RhBug:2170093) #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of no global error occurred within the transaction, we still need to check state of individual transaction items for any failure. This is matching the logic in `BaseCli.do_transaction` method, where the error is emitted after printing the transaction summary. = changelog = msg: automatic: Return an error when transaction fails type: bugfix resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2170093
This was referenced Apr 20, 2023
Closed
m-blaha
approved these changes
May 16, 2023
j-mracek
reviewed
May 16, 2023
| # we need to check state of individual transaction items. | ||
| for tsi in trans: | ||
| if tsi.state == libdnf.transaction.TransactionItemState_ERROR: | ||
| raise dnf.exceptions.Error(_('Transaction failed')) |
There was a problem hiding this comment.
This is not a mistake but an alternative. What about to modify the last live and directly return 1?
logger.error(_('Error: Transaction failed'))
return 1
There was a problem hiding this comment.
I was also considering this, but then I figured there was no real benefit from the change.
There was a problem hiding this comment.
Also the exact same code block is used here from which it was copied.
There was a problem hiding this comment.
We could do some better and deeper refactoring, but I am not sure it's worth it.
There was a problem hiding this comment.
The only benefit is for translators.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of no global error occurred within the transaction, we still need to check state of individual transaction items for any failure.
This is matching the logic in
BaseCli.do_transactionmethod, where the error is emitted after printing the transaction summary.Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2170093.
Tests: rpm-software-management/ci-dnf-stack#1251.