Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More frendly dnf #2081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QuantumLoopHole
Copy link

I made a very slight change to DNF that I think would be fun to implement. It is a smiley face after the complete message.

I don't know how to do this, but it would be interesting if there was a way to customize a message like this on the user's end. Will look into it.

:)

@ppisar
Copy link
Contributor

ppisar commented Apr 16, 2024

While I understand the sentiment, I don't think our enterprise customers would welcome it.

That means I'm against accepting this patch as it is now. A configurable implementation, as you suggested, would not suffer from this problem, and would be, in my opinion, acceptable.

I recommend making the whole "Complete!" message configurable with a default to the current "Complete!". The reason is an internationalization of the message because we cannot assume what way specific languages glue words and sentences together."

@ferdnyc
Copy link
Contributor

ferdnyc commented Jul 29, 2024

While I understand the sentiment, I don't think our enterprise customers would welcome it.

That means I'm against accepting this patch as it is now. A configurable implementation, as you suggested, would not suffer from this problem, and would be, in my opinion, acceptable.

I recommend making the whole "Complete!" message configurable with a default to the current "Complete!". The reason is an internationalization of the message because we cannot assume what way specific languages glue words and sentences together."

In addition to all of this (which is very much YES), if you're going to decorate terminal messages, might as well just take a page from homebrew and use real emoji. #KidsToday won't even know what :) means! 😉

@jackiesogi
Copy link

I was searching for some repositories in order to start my open source contribution journey today, and then I saw this cute PR : )

@QuantumLoopHole
Copy link
Author

I moved over to Arch, but I am booting up a fedora server, so I have a reason to actually build this. If anyone has any suggestions, please send them this way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants