Limit queries to nevra forms when provided by command #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command `dnf install-n <provide>` does not install only according to package mame but still search in provides. The patch limits searrch only to NEVRA forms for install, remove, autoremove, and repoquery commands. Resolves partially: https://issues.redhat.com/browse/RHEL-5747
m-blaha
reviewed
May 23, 2024
| @@ -461,9 +461,10 @@ def run(self): | |||
| if self.opts.key: | |||
| remote_packages = self._add_add_remote_packages() | |||
|
|
|||
| kwark = {} | |||
| kwark = {'with_provides': False} | |||
There was a problem hiding this comment.
We should probably enhance also repoquery documentation a bit to prevent future misunderstandings. It correctly states that query keys are <package-file-spec>. But it also says:
<package-file-spec>
Package specification in the NEVRA format
(name[-[epoch:]version[-re‐lease]][.arch]), a package provide
or a file provide. See Specifying Packages.
I think we should remove the a package provide part from it since repoquery command has never searched in provides.
Repoquery command never matched spec with provides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command
dnf install-n <provide>does not install only according to package mame but still search in provides. The patch limits searrch only to NEVRA forms for install, remove, autoremove, and repoquery commands.Resolves partially: https://issues.redhat.com/browse/RHEL-5747
CI: rpm-software-management/ci-dnf-stack#1509