Modify default value for allow_vendor_change configuration

he new default (false) value improves behavior for users that use third party repository (Copr). If they install a package from alternative provider, DNF will continue to consume updates from the same vendor. Additionally it enables to ship alternative streams using a different vendor.
rpm-software-management · Jun 22, 2023 · 67f9055 · 67f9055
1 parent 46cb1cf
commit 67f9055
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 1 deletion.
diff --git a/doc/changes.rst b/doc/changes.rst
@@ -137,6 +137,12 @@ Upgrade command
 Changes of configuration:
 =========================
 
+Defauilt of `allow_vendor_change` configuration option changed to `false`
+-------------------------------------------------------------------------
+The new default value improves behavior for users that use third party repository (Copr). If they install a package from
+alternative provider, DNF will continue to consume updates from the same vendor. Additionally it enables to ship
+alternative streams using a different vendor.
+
 Default of `best` configuration option changed to `true`
 --------------------------------------------------------
 The new default value ensures that important updates will not be skipped and issues in distribution will be reported

diff --git a/libdnf5/conf/config_main.cpp b/libdnf5/conf/config_main.cpp
@@ -210,7 +210,7 @@ class ConfigMain::Impl {
     OptionBool gpgkey_dns_verification{false};
     OptionBool obsoletes{true};
     OptionBool exit_on_lock{false};
-    OptionBool allow_vendor_change{true};
+    OptionBool allow_vendor_change{false};
     OptionSeconds metadata_timer_sync{60 * 60 * 3};  // 3 hours
     OptionStringList disable_excludes{std::vector<std::string>{}};
     OptionEnum<std::string> multilib_policy{"best", {"best", "all"}};  // :api

diff --git a/test/data/cmdline-rpms/cmdline-1.2-3.spec b/test/data/cmdline-rpms/cmdline-1.2-3.spec
@@ -2,6 +2,7 @@ Name:           cmdline
 Epoch:          0
 Version:        1.2
 Release:        3
+Vendor:         dnf5-test
 
 License:        Public Domain
 URL:            http://example.com/

diff --git a/test/data/repos-rpm/rpm-repo1/one-1-1.spec b/test/data/repos-rpm/rpm-repo1/one-1-1.spec
@@ -2,6 +2,7 @@ Name:           one
 Epoch:          0
 Version:        1
 Release:        1
+Vendor:         dnf5-test
 
 License:        Public Domain
 URL:            http://example.com/

diff --git a/test/data/repos-rpm/rpm-repo1/one-2-1.spec b/test/data/repos-rpm/rpm-repo1/one-2-1.spec
@@ -2,6 +2,7 @@ Name:           one
 Epoch:          0
 Version:        2
 Release:        1
+Vendor:         dnf5-test
 
 License:        Public Domain
 URL:            http://example.com/

diff --git a/test/data/repos-rpm/rpm-repo2/two-2-2.spec b/test/data/repos-rpm/rpm-repo2/two-2-2.spec
@@ -2,6 +2,7 @@ Name:           two
 Epoch:          0
 Version:        2
 Release:        2
+Vendor:         dnf5-test
 
 License:        Public Domain
 URL:            http://example.com/

diff --git a/test/data/repos-solv/solv-distrosync.repo b/test/data/repos-solv/solv-distrosync.repo
@@ -4,3 +4,4 @@
 
 =Pkg: one 1 1 noarch
 =Prv: one = 1-1
+=Vnd: dnf5-test