Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with --repofrompath= and --disablerepo=* #793

Closed
j-mracek opened this issue Aug 2, 2023 · 0 comments · Fixed by #802
Closed

Problem with --repofrompath= and --disablerepo=* #793

j-mracek opened this issue Aug 2, 2023 · 0 comments · Fixed by #802
Assignees
@m-blaha
Labels
good first issue Involves straightforward changes to the codebase; well-suited for first-time contributors Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@j-mracek
Copy link
Contributor

j-mracek commented Aug 2, 2023

--repofrompath= with --disablerepo=* results in disable of all repositories including repository defined in --repofrompath.

In dnf4 - repositories defined by the option were explicitly enabled.
@j-mracek j-mracek added Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take good first issue Involves straightforward changes to the codebase; well-suited for first-time contributors labels Aug 3, 2023
m-blaha added a commit that referenced this issue Aug 4, 2023
@m-blaha
dnf5: --repofrompath repos are always enabled
b4259c9 
Even with --disablerepo=*, the --repofrompath repos should stay enabled.

Resolves: #793
@m-blaha m-blaha mentioned this issue Aug 4, 2023
Merged
m-blaha added a commit that referenced this issue Aug 4, 2023
@m-blaha
dnf5: --repofrompath repos are always enabled
90d3347 
Even with --disablerepo=*, the --repofrompath repos should stay enabled.

Resolves: #793
m-blaha added a commit to rpm-software-management/ci-dnf-stack that referenced this issue Aug 4, 2023
@m-blaha
Test that --disablerepo=* does not affect --repofrompath
5f5731b 
For: rpm-software-management/dnf5#793
@m-blaha m-blaha mentioned this issue Aug 4, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 8, 2023
@m-blaha @kontura
dnf5: --repofrompath repos are always enabled
80b06e2 
Even with --disablerepo=*, the --repofrompath repos should stay enabled.

Resolves: #793
kontura pushed a commit to rpm-software-management/ci-dnf-stack that referenced this issue Aug 8, 2023
@m-blaha @kontura
Test that --disablerepo=* does not affect --repofrompath
ee964f5 
For: rpm-software-management/dnf5#793
@m-blaha m-blaha self-assigned this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-blaha m-blaha

Labels
good first issue Involves straightforward changes to the codebase; well-suited for first-time contributors Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

repo: Error out on creating repo with duplicate id rpm-software-management/dnf5
2 participants
@m-blaha @j-mracek